Discussion:
[PATCH] PCI: imx6q-pcie doc: Update the clocks descriptions to use defines
Fabio Estevam
2014-10-04 14:55:48 UTC
Permalink
From: Fabio Estevam <***@freescale.com>

Let's make the imx6q-pcie example to actually match the usage on imx6qdl.dtsi
by providing the clock names via defines rather than hardcoded numbers.

Signed-off-by: Fabio Estevam <***@freescale.com>
---
Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
index 6fbba53..0b28b52 100644
--- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
+++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
@@ -35,6 +35,8 @@ Example:
<0 0 0 2 &intc GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>,
<0 0 0 3 &intc GIC_SPI 121 IRQ_TYPE_LEVEL_HIGH>,
<0 0 0 4 &intc GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&clks 144>, <&clks 206>, <&clks 189>;
+ clocks = <&clks IMX6QDL_CLK_PCIE_AXI>,
+ <&clks IMX6QDL_CLK_LVDS1_GATE>,
+ <&clks IMX6QDL_CLK_PCIE_REF_125M>;
clock-names = "pcie", "pcie_bus", "pcie_phy";
};
--
1.9.1
Bjorn Helgaas
2014-10-15 00:17:46 UTC
Permalink
[+cc Rob, Arnd, linux-arm-kernel]
Post by Fabio Estevam
Let's make the imx6q-pcie example to actually match the usage on imx6qdl.dtsi
by providing the clock names via defines rather than hardcoded numbers.
Is this an arm-soc thing?

If you want me to take it, I'll wait for an ack from the likes of
Richard/Lucas/Rob/Arnd since I can't review this myself.
Post by Fabio Estevam
---
Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
index 6fbba53..0b28b52 100644
--- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
+++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
<0 0 0 2 &intc GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>,
<0 0 0 3 &intc GIC_SPI 121 IRQ_TYPE_LEVEL_HIGH>,
<0 0 0 4 &intc GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&clks 144>, <&clks 206>, <&clks 189>;
+ clocks = <&clks IMX6QDL_CLK_PCIE_AXI>,
+ <&clks IMX6QDL_CLK_LVDS1_GATE>,
+ <&clks IMX6QDL_CLK_PCIE_REF_125M>;
clock-names = "pcie", "pcie_bus", "pcie_phy";
};
--
1.9.1
H***@freescale.com
2014-10-15 08:28:51 UTC
Permalink
-----Original Message-----
Sent: Wednesday, October 15, 2014 8:18 AM
To: Fabio Estevam
Estevam Fabio-R49496; Zhu Richard-R65037; Rob Herring; Arnd Bergmann; linux-
Subject: Re: [PATCH] PCI: imx6q-pcie doc: Update the clocks descriptions to
use defines
[+cc Rob, Arnd, linux-arm-kernel]
Post by Fabio Estevam
Let's make the imx6q-pcie example to actually match the usage on
imx6qdl.dtsi by providing the clock names via defines rather than hardcoded
numbers.
Is this an arm-soc thing?
If you want me to take it, I'll wait for an ack from the likes of
Richard/Lucas/Rob/Arnd since I can't review this myself.
Hi Bjorn:
yes, this should be an arm-soc stuff.

Hi Fabio:
The prefix of this patch should be ARM: xxxx, and reviewed/merged by shawn.

Best Regards
Richard Zhu
Post by Fabio Estevam
---
Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
index 6fbba53..0b28b52 100644
--- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
+++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
<0 0 0 2 &intc GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>,
<0 0 0 3 &intc GIC_SPI 121 IRQ_TYPE_LEVEL_HIGH>,
<0 0 0 4 &intc GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&clks 144>, <&clks 206>, <&clks 189>;
+ clocks = <&clks IMX6QDL_CLK_PCIE_AXI>,
+ <&clks IMX6QDL_CLK_LVDS1_GATE>,
+ <&clks IMX6QDL_CLK_PCIE_REF_125M>;
clock-names = "pcie", "pcie_bus", "pcie_phy";
};
--
1.9.1
Loading...