Discussion:
[PATCH 3/4] edac: Add DDR3 LRDIMM support, entries in edac_mem_types[]
Aravind Gopalakrishnan
2014-09-18 19:56:58 UTC
Permalink
F15hM60h adds support for DDR4 and DDR3 LRDIMMS. Adding them here.

Signed-off-by: Aravind Gopalakrishnan <***@amd.com>
---
drivers/edac/edac_mc.c | 3 +++
include/linux/edac.h | 2 ++
2 files changed, 5 insertions(+)

diff --git a/drivers/edac/edac_mc.c b/drivers/edac/edac_mc.c
index 9f134823..71fd9fb 100644
--- a/drivers/edac/edac_mc.c
+++ b/drivers/edac/edac_mc.c
@@ -146,6 +146,9 @@ const char *edac_mem_types[] = {
"Rambus XDR",
"Unbuffered DDR3 RAM",
"Registered DDR3 RAM",
+ "Load-Reduce DDR3 RAM",
+ "Unbuffered DDR4 RAM",
+ "Registered DDR4 RAM",
};
EXPORT_SYMBOL_GPL(edac_mem_types);

diff --git a/include/linux/edac.h b/include/linux/edac.h
index e1e68da..7a80100 100644
--- a/include/linux/edac.h
+++ b/include/linux/edac.h
@@ -194,6 +194,7 @@ static inline char *mc_event_error_type(const unsigned int err_type)
* @MEM_DDR3: DDR3 RAM
* @MEM_RDDR3: Registered DDR3 RAM
* This is a variant of the DDR3 memories.
+ * @MEM_LRDDR3 Load-Reduce DDR3 memory
* @MEM_DDR4: DDR4 RAM
* @MEM_RDDR4: Registered DDR4 RAM
* This is a variant of the DDR4 memories.
@@ -216,6 +217,7 @@ enum mem_type {
MEM_XDR,
MEM_DDR3,
MEM_RDDR3,
+ MEM_LRDDR3,
MEM_DDR4,
MEM_RDDR4,
};
--
2.0.2
Borislav Petkov
2014-10-01 11:32:50 UTC
Permalink
Post by Aravind Gopalakrishnan
F15hM60h adds support for DDR4 and DDR3 LRDIMMS. Adding them here.
---
drivers/edac/edac_mc.c | 3 +++
include/linux/edac.h | 2 ++
2 files changed, 5 insertions(+)
diff --git a/drivers/edac/edac_mc.c b/drivers/edac/edac_mc.c
index 9f134823..71fd9fb 100644
--- a/drivers/edac/edac_mc.c
+++ b/drivers/edac/edac_mc.c
@@ -146,6 +146,9 @@ const char *edac_mem_types[] = {
"Rambus XDR",
"Unbuffered DDR3 RAM",
"Registered DDR3 RAM",
+ "Load-Reduce DDR3 RAM",
Renamed it to "Load-Reduced DDR3 RAM" while applying.

Also, applied the following cleanup ontop:

---
From: Borislav Petkov <***@suse.de>
Subject: [PATCH] EDAC: Sync memory types and names

Make keeping the sync between the mem_types enum and the actual string
names simpler by using designated initializers.

Signed-off-by: Borislav Petkov <***@suse.de>
---
drivers/edac/edac_mc.c | 43 ++++++++++++++++++++-----------------------
1 file changed, 20 insertions(+), 23 deletions(-)

diff --git a/drivers/edac/edac_mc.c b/drivers/edac/edac_mc.c
index 129ff9c36a78..1747906f10ce 100644
--- a/drivers/edac/edac_mc.c
+++ b/drivers/edac/edac_mc.c
@@ -125,30 +125,27 @@ static void edac_mc_dump_mci(struct mem_ctl_info *mci)

#endif /* CONFIG_EDAC_DEBUG */

-/*
- * keep those in sync with the enum mem_type
- */
const char * const edac_mem_types[] = {
- "Empty csrow",
- "Reserved csrow type",
- "Unknown csrow type",
- "Fast page mode RAM",
- "Extended data out RAM",
- "Burst Extended data out RAM",
- "Single data rate SDRAM",
- "Registered single data rate SDRAM",
- "Double data rate SDRAM",
- "Registered Double data rate SDRAM",
- "Rambus DRAM",
- "Unbuffered DDR2 RAM",
- "Fully buffered DDR2",
- "Registered DDR2 RAM",
- "Rambus XDR",
- "Unbuffered DDR3 RAM",
- "Registered DDR3 RAM",
- "Load-Reduced DDR3 RAM",
- "Unbuffered DDR4 RAM",
- "Registered DDR4 RAM",
+ [MEM_EMPTY] = "Empty csrow",
+ [MEM_RESERVED] = "Reserved csrow type",
+ [MEM_UNKNOWN] = "Unknown csrow type",
+ [MEM_FPM] = "Fast page mode RAM",
+ [MEM_EDO] = "Extended data out RAM",
+ [MEM_BEDO] = "Burst Extended data out RAM",
+ [MEM_SDR] = "Single data rate SDRAM",
+ [MEM_RDR] = "Registered single data rate SDRAM",
+ [MEM_DDR] = "Double data rate SDRAM",
+ [MEM_RDDR] = "Registered Double data rate SDRAM",
+ [MEM_RMBS] = "Rambus DRAM",
+ [MEM_DDR2] = "Unbuffered DDR2 RAM",
+ [MEM_FB_DDR2] = "Fully buffered DDR2",
+ [MEM_RDDR2] = "Registered DDR2 RAM",
+ [MEM_XDR] = "Rambus XDR",
+ [MEM_DDR3] = "Unbuffered DDR3 RAM",
+ [MEM_RDDR3] = "Registered DDR3 RAM",
+ [MEM_LRDDR3] = "Load-Reduced DDR3 RAM",
+ [MEM_DDR4] = "Unbuffered DDR4 RAM",
+ [MEM_RDDR4] = "Registered DDR4 RAM",
};
EXPORT_SYMBOL_GPL(edac_mem_types);
--
2.0.0
--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
Loading...