[PATCH v2] PCI: tegra: Enable root port specific features

[Vidya Sagar]

Enables root port to advertise its ASPM-L1 capability
resulting in possible link entry to L1 when an ASPM-L1 capable
device is connected
Enables per-controller & per-TMS clock clamping by default
Enabling above features result in more power saving

It also avoids PM message truncation by waiting for DLLP to finish
before entering into L1 or L2

Signed-off-by: Vidya Sagar <vidyas-DDmLM1+adcrQT0dZR+***@public.gmane.org>
---
v2:
Removed rp_read() & rp_write() as they seem to be redundant
Moved port disable code under error condition i.e. it the link
is down, corresponding port will be disabled

drivers/pci/host/pci-tegra.c | 50 +++++++++++++++++++++++++++++++++++++++-----
1 file changed, 45 insertions(+), 5 deletions(-)

diff --git a/drivers/pci/host/pci-tegra.c b/drivers/pci/host/pci-tegra.c
index 3d43874..7f32b07 100644
--- a/drivers/pci/host/pci-tegra.c
+++ b/drivers/pci/host/pci-tegra.c
@@ -237,6 +237,18 @@
(0xf << PADS_REFCLK_CFG_DRVI_SHIFT) \
)

+#define NV_PCIE2_RP_VEND_XP1 0x00000F04
+#define NV_PCIE2_RP_VEND_XP_LINK_PVT_CTL_L1_ASPM_SUPPORT (1 << 21)
+
+#define NV_PCIE2_RP_VEND_XP_BIST 0x00000F4C
+#define PCIE2_RP_VEND_XP_BIST_GOTO_L1_L2_AFTER_DLLP_DONE (1 << 28)
+
+#define NV_PCIE2_RP_PRIV_MISC 0x00000FE0
+#define PCIE2_RP_PRIV_MISC_CTLR_CLK_CLAMP_THRESHOLD (0xF << 16)
+#define PCIE2_RP_PRIV_MISC_CTLR_CLK_CLAMP_ENABLE (1 << 23)
+#define PCIE2_RP_PRIV_MISC_TMS_CLK_CLAMP_THRESHOLD (0xF << 24)
+#define PCIE2_RP_PRIV_MISC_TMS_CLK_CLAMP_ENABLE (1 << 31)
+
struct tegra_msi {
struct msi_chip chip;
DECLARE_BITMAP(used, INT_PCI_MSI_NR);
@@ -1859,6 +1871,32 @@ retry:
return false;
}

+/* Enable various features of root port */
+static void tegra_pcie_enable_rp_features(struct tegra_pcie_port *port)
+{
+ unsigned int data;
+
+ /* Power mangagement settings */
+ /* Enable clock clamping by default */
+ data = readl(port->base + NV_PCIE2_RP_PRIV_MISC);
+ data |= PCIE2_RP_PRIV_MISC_CTLR_CLK_CLAMP_THRESHOLD |
+ PCIE2_RP_PRIV_MISC_CTLR_CLK_CLAMP_ENABLE |
+ PCIE2_RP_PRIV_MISC_TMS_CLK_CLAMP_THRESHOLD |
+ PCIE2_RP_PRIV_MISC_TMS_CLK_CLAMP_ENABLE;
+ writel(data, port->base + NV_PCIE2_RP_PRIV_MISC);
+
+ /* Enable rootport to advertise its ASPM - L1 capability */
+ data = readl(port->base + NV_PCIE2_RP_VEND_XP1);
+ data |= NV_PCIE2_RP_VEND_XP_LINK_PVT_CTL_L1_ASPM_SUPPORT;
+ writel(data, port->base + NV_PCIE2_RP_VEND_XP1);
+
+ /* LTSSM : wait for DLLP to finish before entering L1 or L2/L3 */
+ /* to avoid truncating PM messages resulting in receiver errors */
+ data = readl(port->base + NV_PCIE2_RP_VEND_XP_BIST);
+ data |= PCIE2_RP_VEND_XP_BIST_GOTO_L1_L2_AFTER_DLLP_DONE;
+ writel(data, port->base + NV_PCIE2_RP_VEND_XP_BIST);
+}
+
static int tegra_pcie_enable(struct tegra_pcie *pcie)
{
struct tegra_pcie_port *port, *tmp;
@@ -1870,13 +1908,15 @@ static int tegra_pcie_enable(struct tegra_pcie *pcie)

tegra_pcie_port_enable(port);

- if (tegra_pcie_port_check_link(port))
+ if (!tegra_pcie_port_check_link(port)) {
+ dev_info(pcie->dev, "link %u down, ignoring\n",
+ port->index);
+ tegra_pcie_port_disable(port);
+ tegra_pcie_port_free(port);
continue;
+ }

- dev_info(pcie->dev, "link %u down, ignoring\n", port->index);
-
- tegra_pcie_port_disable(port);
- tegra_pcie_port_free(port);
+ tegra_pcie_enable_rp_features(port);
}

memset(&hw, 0, sizeof(hw));